statedb.go: fix NoTries mode snapshot storage delete#3501
Merged
buddh0 merged 2 commits intobnb-chain:developfrom Dec 24, 2025
Merged
statedb.go: fix NoTries mode snapshot storage delete#3501buddh0 merged 2 commits intobnb-chain:developfrom
buddh0 merged 2 commits intobnb-chain:developfrom
Conversation
buddh0
reviewed
Dec 24, 2025
Contributor
|
this bug exists more than 2 years, no later than PR https://github.com/bnb-chain/bsc/pull/1840/files |
Contributor
|
after cancun, with EIP-6780, no wiping out old storages then. |
buddh0
approved these changes
Dec 24, 2025
Contributor
|
fix issue #3487 |
zzzckck
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In NoTries mode (
--tries-verify-mode none), storage data is not properly deleted from the snapshot whenhandleDestructionis called during SELFDESTRUCT.Rationale
In NoTries mode,
stateObject.updateRoot()always setsRoottoEmptyRootHashregardless of actual storage content:This causes two issues in the SELFDESTRUCT flow:
handleDestructionskips storage deletion: The checkprev.Root == types.EmptyRootHashincorrectly assumes no storage exists, bypassingdeleteStorage().fastDeleteStoragehash verification fails: Even ifdeleteStorageis called, the hash checkstack.Hash() != rootfails becauserootisEmptyRootHashbut the actual storage hash is not.Example
add an example CLI or API response...
Changes
Notable changes: